Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch config upgrade to use xdr instead of json #519

Closed
leighmcculloch opened this issue Nov 3, 2023 · 0 comments · Fixed by #524
Closed

Switch config upgrade to use xdr instead of json #519

leighmcculloch opened this issue Nov 3, 2023 · 0 comments · Fixed by #524
Assignees

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Nov 3, 2023

The quickstart image needs changing how it does config upgrades, so instead of giving stellar-core a json file for the config to upgrade to, it gives it xdr.

In #513 we added config upgrades using the json format.

However, stellar-core is being updated to remove the json dependency and will just accept xdr.

The stellar-core command we started using in 513 already supports both xdr and json, so we can switch at any point but need to switch before the v20 release of stellar-core.

cc @sisuresh @anupsdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants