Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge for allocation of new ParsedModule #1372

Closed
jayz22 opened this issue Mar 26, 2024 · 1 comment
Closed

Charge for allocation of new ParsedModule #1372

jayz22 opened this issue Mar 26, 2024 · 1 comment

Comments

@jayz22
Copy link
Contributor

jayz22 commented Mar 26, 2024

#1359 (comment)

@graydon
Copy link
Contributor

graydon commented Mar 29, 2024

Actually I am going to have to revert this -- it doesn't work and isn't necessary. It doesn't work because the existing structure is part of Vm::new and is put in an Rc there with Rc::new but not separately metered, so starting to meter it breaks replay. And it's not necessary since it's actually counted as part of the constant term in the cost of instantiation (or now parsing).

@jayz22 jayz22 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants