feat!: remove all logging #8
Open
+6
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineHeffron
changed the title
This was referenced Jul 29, 2024
willemneal
force-pushed
the
feat/diagnostic_events_decode
branch
from
6a7538a to
0f9c342
Compare
This crate is a thin wrapper, which calls RPC. Thus logged data is available to the caller be it the error, result or data passed in.
willemneal
force-pushed
the
feat/diagnostic_events_decode
branch
from
0f9c342 to
91a625b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove tracing and all logging from crate.
Why
This crate is a thin wrapper around an HTTP client. Thus the caller has the info either what is passed in or the results of the calls. So no benefit is gained from logging.
CLI should be responsible for logging, see stellar/stellar-cli#1447 (comment)
Known limitations
Breaking change since it removes all log statements.