Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses in JSON are rendered as JSON objects containing hex strings but should be strkeys #300

Closed
leighmcculloch opened this issue Sep 8, 2023 · 0 comments · Fixed by #315 or #313
Assignees
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

What version are you using?

bda0d98

What did you do?

Use serde_json to convert values in this crate to JSON, that contain the ScVal::Address value.

What did you expect to see?

The strkey representation of the address. e.g. A... or C...

What did you see instead?

{
    "address": {
        "contract": "fc21c6967fda947c012695d185c9f78bcb97e380c6811d12f4b525f6fb54f9a0"
    }
}
@leighmcculloch leighmcculloch added the bug Something isn't working label Sep 8, 2023
@dmkozh dmkozh added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Oct 5, 2023
@leighmcculloch leighmcculloch self-assigned this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants