Remove guard from function and bring it to the caller.

stellar · Jun 14, 2024 · 1348467 · 1348467
1 parent 1f540a7
commit 1348467
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/cmd/soroban-cli/src/commands/config/alias.rs b/cmd/soroban-cli/src/commands/config/alias.rs
@@ -32,7 +32,7 @@ pub enum Error {
 }
 
 impl Args {
-    pub fn load(&self, alias: &str) -> Result<Option<Data>, Error> {
+    fn load(&self, alias: &str) -> Result<Option<Data>, Error> {
         let path = self.alias_path(alias)?;
 
         if !path.exists() {
@@ -51,11 +51,7 @@ impl Args {
         Ok(config_dir.join("contract-ids").join(file_name))
     }
 
-    pub fn save_contract_id(&self, contract_id: &str, alias: Option<&String>) -> Result<(), Error> {
-        let Some(alias) = alias else {
-            return Ok(());
-        };
-
+    pub fn save_contract_id(&self, contract_id: &str, alias: &str) -> Result<(), Error> {
         let path = self.alias_path(alias)?;
         let dir = path.parent().ok_or(Error::CannotAccessConfigDir)?;
 

diff --git a/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs b/cmd/soroban-cli/src/commands/contract/deploy/wasm.rs
@@ -120,8 +120,9 @@ impl Cmd {
         match res {
             TxnEnvelopeResult::TxnEnvelope(tx) => println!("{}", tx.to_xdr_base64(Limits::none())?),
             TxnEnvelopeResult::Res(contract) => {
-                self.config
-                    .save_contract_id(&contract, self.alias.as_ref())?;
+                if let Some(alias) = self.alias.clone() {
+                    self.config.save_contract_id(&contract, &alias)?;
+                }
 
                 println!("{contract}");
             }