From d11c7e0750311d149d5f85d5e44ab6e4f1f2e6cb Mon Sep 17 00:00:00 2001
From: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Date: Fri, 30 Aug 2024 08:20:59 -0400
Subject: [PATCH] fix(init): use String, not Symbol, in hello_world (#1577)

Updates `hello_world` to match the version that has been in
`soroban-examples` since https://github.com/stellar/soroban-examples/pull/314
---
 .../contracts/hello_world/src/lib.rs                   |  6 +++---
 .../contracts/hello_world/src/test.rs                  | 10 +++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/lib.rs b/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/lib.rs
index fb23e5055..f3eb78a36 100644
--- a/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/lib.rs
+++ b/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/lib.rs
@@ -1,13 +1,13 @@
 #![no_std]
-use soroban_sdk::{contract, contractimpl, symbol_short, vec, Env, Symbol, Vec};
+use soroban_sdk::{contract, contractimpl, vec, Env, String, Vec};
 
 #[contract]
 pub struct HelloContract;
 
 #[contractimpl]
 impl HelloContract {
-    pub fn hello(env: Env, to: Symbol) -> Vec<Symbol> {
-        vec![&env, symbol_short!("Hello"), to]
+    pub fn hello(env: Env, to: String) -> Vec<String> {
+        vec![&env, String::from_str(&env, "Hello"), to]
     }
 }
 
diff --git a/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/test.rs b/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/test.rs
index e72c6bb9f..4b250446a 100644
--- a/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/test.rs
+++ b/cmd/soroban-cli/src/utils/contract-init-template/contracts/hello_world/src/test.rs
@@ -1,7 +1,7 @@
 #![cfg(test)]
 
 use super::*;
-use soroban_sdk::{symbol_short, vec, Env};
+use soroban_sdk::{vec, Env, String};
 
 #[test]
 fn test() {
@@ -9,9 +9,13 @@ fn test() {
     let contract_id = env.register_contract(None, HelloContract);
     let client = HelloContractClient::new(&env, &contract_id);
 
-    let words = client.hello(&symbol_short!("Dev"));
+    let words = client.hello(&String::from_str(&env, "Dev"));
     assert_eq!(
         words,
-        vec![&env, symbol_short!("Hello"), symbol_short!("Dev"),]
+        vec![
+            &env,
+            String::from_str(&env, "Hello"),
+            String::from_str(&env, "Dev"),
+        ]
     );
 }