From c6c26e515c3eafab505d058ea2a14b0abf4d0197 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Wed, 13 Sep 2023 14:43:51 -0700 Subject: [PATCH] update the optional env parameters for empty value usage --- .github/workflows/e2e.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index b72a8f8a4..c5299d5fb 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -24,8 +24,9 @@ jobs: # the core bin can either be compiled in-line here as part of ci, SYSTEM_TEST_CORE_GIT_REF: https://github.com/stellar/stellar-core.git#ecb24df104c2453a00fa5097d2e879d7731b9596 SYSTEM_TEST_CORE_COMPILE_CONFIGURE_FLAGS: "--disable-tests --enable-next-protocol-version-unsafe-for-production" - # or can use option to pull a pre-compiled image instead - # SYSTEM_TEST_CORE_IMAGE: + # or set SYSTEM_TEST_CORE_GIT_REF to empty, and set SYSTEM_TEST_CORE_IMAGE + # to pull a pre-compiled image from dockerhub instead + SYSTEM_TEST_CORE_IMAGE: # sets the version of rust toolchain that will be pre-installed in the # test runtime environment, tests invoke rustc/cargo @@ -37,9 +38,10 @@ jobs: # option #1, set the version of soroban-js-client based on a npm release version SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION: 1.0.0-beta.0 # option #2, set the version of soroban-js-client used as a ref to a gh repo - # if this value is present it takes precedence over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION - # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: stellar/js-soroban-client - # SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: refs/pull/135/head + # if a value is set on SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO, it takes precedence + # over any SYSTEM_TEST_JS_SOROBAN_CLIENT_NPM_VERSION + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO: + SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REF: # system test will build quickstart image internally to use for running the service stack # configured in standalone network mode(core, rpc) @@ -62,11 +64,11 @@ jobs: name: checkout soroban-tools with: path: soroban-tools - - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} + - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO != ''}} name: prepare local js-soroban-client run: | rm -rf $GITHUB_WORKSPACE/system-test/js-soroban-client; - - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }} + - if: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO != ''}} uses: actions/checkout@v3 with: repository: ${{ env.SYSTEM_TEST_JS_SOROBAN_CLIENT_GH_REPO }}