From e26599a5ed44a013548be9acad758ee4bbeb2273 Mon Sep 17 00:00:00 2001 From: Willem Wyndham Date: Tue, 9 Jul 2024 15:03:05 -0400 Subject: [PATCH] fix: remove ledger stuff and add comment to tx sign --- .github/workflows/binaries.yml | 3 --- .github/workflows/e2e.yml | 3 --- .github/workflows/full-help-docs.yml | 3 --- .github/workflows/rpc-tests.yml | 3 --- Cargo.toml | 4 ---- FULL_HELP_DOCS.md | 2 +- cmd/soroban-cli/src/commands/tx/sign.rs | 1 + 7 files changed, 2 insertions(+), 17 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 4d8440cd5..97304b7bd 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -39,9 +39,6 @@ jobs: - run: rustup target add ${{ matrix.sys.target }} - if: matrix.sys.target == 'aarch64-unknown-linux-gnu' run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu - - if: matrix.sys.target == 'aarch64-unknown-linux-gnu' - run: | - sudo apt install -y libudev-dev - name: Setup vars run: | version="$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "stellar-cli") | .version')" diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 2b02b4f5c..0704d4a55 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -84,9 +84,6 @@ jobs: path: system-test/js-stellar-sdk - uses: stellar/actions/rust-cache@main - - name: install libudev-dev - run: | - sudo apt install -y libudev-dev - name: Build system test with component versions run: | cd $GITHUB_WORKSPACE/system-test diff --git a/.github/workflows/full-help-docs.yml b/.github/workflows/full-help-docs.yml index f8f61521c..4893a88fd 100644 --- a/.github/workflows/full-help-docs.yml +++ b/.github/workflows/full-help-docs.yml @@ -14,9 +14,6 @@ jobs: - uses: actions/checkout@v3 - uses: stellar/actions/rust-cache@main - run: rustup update - - name: install libudev-dev - run: | - sudo apt install -y libudev-dev - name: Generate help doc # this looks goofy to get GITHUB_OUTPUT to work with multi-line return values; # see https://stackoverflow.com/a/74266196/249801 diff --git a/.github/workflows/rpc-tests.yml b/.github/workflows/rpc-tests.yml index b9279ab95..ad999830a 100644 --- a/.github/workflows/rpc-tests.yml +++ b/.github/workflows/rpc-tests.yml @@ -35,9 +35,6 @@ jobs: target/ key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} - run: rustup update - - name: install libudev-dev - run: | - sudo apt install -y libudev-dev - run: cargo build - run: rustup target add wasm32-unknown-unknown - run: make build-test-wasms diff --git a/Cargo.toml b/Cargo.toml index 384bb996c..0f22a48db 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -51,10 +51,6 @@ version = "=21.1.1" version = "=21.1.0" path = "cmd/soroban-cli" -[workspace.dependencies.stellar-ledger] -version = "=21.0.0" -path = "cmd/crates/stellar-ledger" - [workspace.dependencies.soroban-rpc] package = "stellar-rpc-client" version = "21.3.1" diff --git a/FULL_HELP_DOCS.md b/FULL_HELP_DOCS.md index fe3c48155..f84a9074e 100644 --- a/FULL_HELP_DOCS.md +++ b/FULL_HELP_DOCS.md @@ -1314,7 +1314,7 @@ Sign a transaction * `--global` — Use global config * `--config-dir ` — Location of config directory, default is "." * `--check` — Check with user before signature. Eventually this will be replaced with `--yes`, which does the opposite and will force a check without --yes -* `-a`, `--auth-only` +* `-a`, `--auth-only` — Only sign the Authorization Entries required by the provided source account diff --git a/cmd/soroban-cli/src/commands/tx/sign.rs b/cmd/soroban-cli/src/commands/tx/sign.rs index 8714470ac..5fb48d2b5 100644 --- a/cmd/soroban-cli/src/commands/tx/sign.rs +++ b/cmd/soroban-cli/src/commands/tx/sign.rs @@ -17,6 +17,7 @@ pub enum Error { pub struct Cmd { #[clap(flatten)] pub config: config::Args, + /// Only sign the Authorization Entries required by the provided source account #[arg(long, visible_alias = "auth", short = 'a')] pub auth_only: bool, }