Clippy

Author: elizabethengelman

cmd/soroban-cli/src/commands/contract/deploy/asset.rs

@@ -96,7 +96,7 @@ impl NetworkRunnable for Cmd {
         let asset = parse_asset(&self.asset)?;
 
         let network = config.get_network()?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         client
             .verify_network_passphrase(Some(&network.network_passphrase))
             .await?;

cmd/soroban-cli/src/commands/contract/deploy/wasm.rs

@@ -211,7 +211,7 @@ impl NetworkRunnable for Cmd {
             None => rand::thread_rng().gen::<[u8; 32]>(),
         };
 
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         client
             .verify_network_passphrase(Some(&network.network_passphrase))
             .await?;

cmd/soroban-cli/src/commands/contract/extend.rs

@@ -133,7 +133,7 @@ impl NetworkRunnable for Cmd {
         let network = config.get_network()?;
         tracing::trace!(?network);
         let keys = self.key.parse_keys(&config.locator, &network)?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let key = config.source_account()?;
         let extend_to = self.ledgers_to_extend();
 

cmd/soroban-cli/src/commands/contract/info/shared.rs

@@ -74,7 +74,7 @@ pub async fn fetch_wasm(args: &Args) -> Result<Option<Vec<u8>>, Error> {
 
         let hash = xdr::Hash(hash);
 
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(network)?;
 
         client
             .verify_network_passphrase(Some(&network.network_passphrase))

cmd/soroban-cli/src/commands/contract/install.rs

@@ -108,7 +108,7 @@ impl NetworkRunnable for Cmd {
         let config = config.unwrap_or(&self.config);
         let contract = self.wasm.read()?;
         let network = config.get_network()?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         client
             .verify_network_passphrase(Some(&network.network_passphrase))
             .await?;

cmd/soroban-cli/src/commands/contract/invoke.rs

@@ -214,7 +214,7 @@ impl NetworkRunnable for Cmd {
             // For testing wasm arg parsing
             let _ = build_host_function_parameters(&contract_id, &self.slop, spec_entries, config)?;
         }
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let account_details = if self.is_view {
             default_account_entry()
         } else {

cmd/soroban-cli/src/commands/contract/read.rs

@@ -188,7 +188,7 @@ impl NetworkRunnable for Cmd {
         let config = config.unwrap_or(&self.config);
         let network = config.get_network()?;
         tracing::trace!(?network);
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let keys = self.key.parse_keys(&config.locator, &network)?;
         Ok(client.get_full_ledger_entries(&keys).await?)
     }

cmd/soroban-cli/src/commands/contract/restore.rs

@@ -136,7 +136,7 @@ impl NetworkRunnable for Cmd {
         let network = config.get_network()?;
         tracing::trace!(?network);
         let entry_keys = self.key.parse_keys(&config.locator, &network)?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let key = config.source_account()?;
 
         // Get the account sequence number

cmd/soroban-cli/src/commands/events.rs

@@ -212,7 +212,7 @@ impl NetworkRunnable for Cmd {
             self.network.get(&self.locator)
         }?;
 
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         client
             .verify_network_passphrase(Some(&network.network_passphrase))
             .await?;

cmd/soroban-cli/src/commands/tx/send.rs

@@ -57,7 +57,7 @@ impl NetworkRunnable for Cmd {
         } else {
             self.network.get(&self.locator)?
         };
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let tx_env = super::xdr::tx_envelope_from_stdin()?;
         Ok(client.send_transaction_polling(&tx_env).await?)
     }

cmd/soroban-cli/src/commands/tx/simulate.rs

@@ -51,7 +51,7 @@ impl NetworkRunnable for Cmd {
     ) -> Result<Self::Result, Self::Error> {
         let config = config.unwrap_or(&self.config);
         let network = config.get_network()?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let tx = super::xdr::unwrap_envelope_v1(super::xdr::tx_envelope_from_stdin()?)?;
         Ok(client.simulate_and_assemble_transaction(&tx).await?)
     }

cmd/soroban-cli/src/config/mod.rs

@@ -102,7 +102,7 @@ impl Args {
     ) -> Result<Option<Transaction>, Error> {
         let network = self.get_network()?;
         let source_key = self.key_pair()?;
-        let client = RpcClient::new(network.clone())?;
+        let client = RpcClient::new(&network)?;
         let latest_ledger = client.get_latest_ledger().await?.sequence;
         let seq_num = latest_ledger + 60; // ~ 5 min
         Ok(signer::sign_soroban_authorizations(

cmd/soroban-cli/src/rpc_client.rs

@@ -21,9 +21,9 @@ pub struct RpcClient {
 }
 
 impl RpcClient {
-    pub fn new(network: Network) -> Result<Self, Error> {
+    pub fn new(network: &Network) -> Result<Self, Error> {
         let mut additional_headers = HeaderMap::new();
-        for header in network.rpc_headers.iter() {
+        for header in &network.rpc_headers {
             let header_name = HeaderName::from_bytes(header.0.as_bytes())?;
             let header_value = HeaderValue::from_str(&header.1)?;
 
@@ -64,7 +64,7 @@ mod tests {
             rpc_headers: [("api key".to_string(), "Bearer".to_string())].to_vec(),
         };
 
-        let result = RpcClient::new(network);
+        let result = RpcClient::new(&network);
 
         assert!(result.is_err());
         assert_eq!(
@@ -81,7 +81,7 @@ mod tests {
             rpc_headers: [("Authorization".to_string(), "Bearer 1234".to_string())].to_vec(),
         };
 
-        let result = RpcClient::new(network);
+        let result = RpcClient::new(&network);
 
         assert!(result.is_ok());
     }
@@ -94,7 +94,7 @@ mod tests {
             rpc_headers: [("authorization".to_string(), "bearer 1234".to_string())].to_vec(),
         };
 
-        let result = RpcClient::new(network);
+        let result = RpcClient::new(&network);
 
         assert!(result.is_ok());
     }
@@ -107,7 +107,7 @@ mod tests {
             rpc_headers: [].to_vec(),
         };
 
-        let result = RpcClient::new(network);
+        let result = RpcClient::new(&network);
 
         assert!(result.is_ok());
     }
@@ -124,7 +124,7 @@ mod tests {
             .to_vec(),
         };
 
-        let result = RpcClient::new(network);
+        let result = RpcClient::new(&network);
 
         assert!(result.is_ok());
     }

cmd/soroban-cli/src/wasm.rs

@@ -129,7 +129,7 @@ pub async fn fetch_from_contract(
         .resolve_contract_id(contract_id, &network.network_passphrase)?
         .0;
 
-    let client = RpcClient::new(network.clone())?;
+    let client = RpcClient::new(network)?;
     client
         .verify_network_passphrase(Some(&network.network_passphrase))
         .await?;