soroban-cli: unhandled error panick in invoke code

[leighmcculloch]

This issue is lifting a report shared and experienced by someone else in Discord.

What version are you using?

I think it's v20.0.0-rc4, but can't be certain.

What did you do?

Hi folks, I'm working on the Soroban Quest, the first one "Hello World" compiles fine and deploys fine but I am unable to invoke. Here are the steps I took:

1. Logged into the SQ Gitpod (via Discord)
2. Generated a keypair (public key GBPC7EJR7A7FEVXLSADKJJ4PKNL2ABSVYMXAHOO736F25C5HHGONOCAW)
3. Funded it
4. Built it - soroban contract build (seems like hello world compiles fine but quest 5 throws errors)
5. Create an alice identity as per - https://soroban.stellar.org/docs/getting-started/deploy-to-testnet and setup testnet
6. Deployed and stored returned contract address to ./soroban/hello-id
   soroban contract deploy
   --wasm target/wasm32-unknown-unknown/release/soroban_hello_world_contract.wasm
   --source alice
   --network testnet
7. When invoking

soroban contract invoke --id $(cat ../../.soroban/hello-id) --source alice --network testnet

Ref: https://discord.com/channels/897514728459468821/966788672164855829/1170881122213822495

What did you expect to see?

Successful invoke or help messages or helpful error message.

What did you see instead?

thread 'main' panicked at 'called Option::unwrap() on a None value', src/commands/contract/invoke.rs:188:66
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Ref: https://discord.com/channels/897514728459468821/966788672164855829/1170881122213822495

Discussion

Looking at the command being executed it appears like the invoke contract function is missing. However, even if it's missing or the command isn't formed correctly we shouldn't be panicking.

This is the line of code that I think panicked:

https://github.com/stellar/soroban-tools/blob/bce5e56ba16ba977200b022c91f3eaf6282f47eb/cmd/soroban-cli/src/commands/contract/invoke.rs#L188

Seems like this is an error case we should be handling instead of using unwrap.