Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-snapshots causes permadiffs #1087

Open
leighmcculloch opened this issue Nov 16, 2023 · 2 comments
Open

build-snapshots causes permadiffs #1087

leighmcculloch opened this issue Nov 16, 2023 · 2 comments

Comments

@leighmcculloch
Copy link
Member

When running make build-snapshots files keep getting written that appear as permanent diffs.

Either these files need ignoring from git, or need updating, but it is unclear to me which is the path to take.

cc @chadoh

@stellarsaur
Copy link
Contributor

After looking at the generated files, it doesn't look like these should be tracked. So IMO it would be best adding the outputted files to .gitignore. Open to hearing other's thoughts

@chadoh
Copy link
Contributor

chadoh commented Nov 20, 2023

These files are used in the tests in cmd/crates/soroban-spec-typescript/boilerplate.rs

I think we (used to) have a CI step to make sure that these artifacts are not stale. Maybe it was ignored, and that's why we're getting perma-diffs on main now? Or maybe it was turned off?

For now, we should probably commit the diffs. After #1037 is merged, maybe we can get rid of them, since this will do much better than just making sure the built artifacts match what we expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants