Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: make preflight fudge factors configurable by the client #1128

Closed
mollykarcher opened this issue Dec 12, 2023 · 0 comments · Fixed by #1131
Closed

soroban-rpc: make preflight fudge factors configurable by the client #1128

mollykarcher opened this issue Dec 12, 2023 · 0 comments · Fixed by #1131
Assignees

Comments

@mollykarcher
Copy link
Contributor

mollykarcher commented Dec 12, 2023

What problem does your feature solve?

Preflight estimations have been off, requiring us to repeatedly issue releases to up the fudge factor used in these calculations. When users are unable to create contracts due to these issues, there aren't any good workarounds for them.

What would you like to see?

The preflight request will accept new parameters that translate into the fudge factor used by preflight. TBD whether we should support/add both the percentage and flat addition factors, or if we should just support one or the other. End users could then tweak this up or down depending on their specific needs. These parameters should be optional and the default should be the current hardcoded values. Optionally, we could make these defaults configurable RPC/server side as well.

What alternatives are there?

Alternatively discussed making the fudge factor(s) configurable RPC-side. This would still allow us and other RPC providers to move the fudge factor without having to release/deploy. However, given a single RPC instance will service many different profiles of dapps/users, and it's impossible to provide a one-size-fits-all default that will work for all contracts, it makes more sense for it to be client provided.

@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Dec 12, 2023
@mollykarcher mollykarcher added this to the Soroban Pubnet Release milestone Dec 12, 2023
@stellarsaur stellarsaur self-assigned this Dec 12, 2023
@stellarsaur stellarsaur moved this from Next Sprint Proposal to In Progress in Platform Scrum Dec 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants