Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: add flag for fiddling with the fudge factor #1148

Open
kalepail opened this issue Jan 2, 2024 · 5 comments
Open

soroban-cli: add flag for fiddling with the fudge factor #1148

kalepail opened this issue Jan 2, 2024 · 5 comments
Labels
cli Related to Soroban CLI

Comments

@kalepail
Copy link
Contributor

kalepail commented Jan 2, 2024

What problem does your feature solve?

We now have the ability to modify the simulation fudge factor but the CLI doesn't expose it. This would allow for that

What alternatives are there?

Use the JS SDK which has added this feature

@kalepail
Copy link
Contributor Author

kalepail commented Jan 2, 2024

cc: @mollykarcher @janewang

@mollykarcher mollykarcher added the cli Related to Soroban CLI label Jan 2, 2024
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Jan 2, 2024
@willemneal willemneal self-assigned this Jan 2, 2024
@janewang
Copy link
Contributor

janewang commented Jan 3, 2024

@tyvdh @leighmcculloch Thanks for opening this. Will the fudge factor eventually going away once there is more accurate gas estimation?

@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Jan 4, 2024
@2opremio
Copy link
Contributor

2opremio commented Jan 8, 2024

I think that the fudge factor will stay for now (probably even with more accurate estimations)

@2opremio
Copy link
Contributor

2opremio commented Jan 8, 2024

BTW, isn't this a duplicate of #1130 ?

@leighmcculloch leighmcculloch changed the title Add a cli flag for fiddling with the fudge factor soroban-cli: add flag for fiddling with the fudge factor Jan 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DevX Jan 29, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

This issue is stale because it has been assigned for 30 days with no activity. It will be closed in 30 days unless the stale label is removed, and the assignee is removed or updated.

@github-actions github-actions bot added the stale label Dec 8, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Jan 10, 2025
@janewang janewang removed the stale label Jan 10, 2025
@janewang janewang reopened this Jan 10, 2025
@janewang janewang moved this from Done to Todo (Ready for Dev) in DevX Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to Soroban CLI
Projects
Status: Todo (Ready for Dev)
Development

No branches or pull requests

6 participants
@janewang @willemneal @mollykarcher @2opremio @kalepail and others