Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding accounts errors with invalid uri error #1251

Closed
leighmcculloch opened this issue Mar 10, 2024 · 1 comment · Fixed by #1257
Closed

Funding accounts errors with invalid uri error #1251

leighmcculloch opened this issue Mar 10, 2024 · 1 comment · Fixed by #1257
Assignees
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Mar 10, 2024

What version are you using?

Broken in 38d8650 (main)

What did you do?

Generated a new key that also automatically gets funded:

$ soroban keys generate \
    --rpc-url https://soroban-testnet.stellar.org:443 \
    --network-passphrase 'Test SDF Network ; September 2015' \
    me

What did you expect to see?

Successfully funded account, like it worked in ae5446f (v2.3.1).

What did you see instead?

$ soroban keys generate \
    --rpc-url https://soroban-testnet.stellar.org:443 \
    --network-passphrase 'Test SDF Network ; September 2015' \
    me
2024-03-10T00:32:26.229192Z ERROR soroban_cli::commands::network: invalid uri character
2024-03-10T00:32:26.229550Z  WARN soroban_cli::commands::keys::generate: fund_address failed: Invalid URL https://friendbot.stellar.org/
@leighmcculloch leighmcculloch added the bug Something isn't working label Mar 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DevX Mar 10, 2024
@leighmcculloch leighmcculloch changed the title Funding accounts broken in latest release Funding accounts broken Mar 10, 2024
@leighmcculloch leighmcculloch changed the title Funding accounts broken Funding accounts errors with invalid uri error Mar 10, 2024
@willemneal
Copy link
Member

Can confirm locally! Looking into it! I changed the way that friendbot url is parsed from RPC because if using the local quickstart the friendbot url is hardcoded to use port 8000.

@willemneal willemneal self-assigned this Mar 12, 2024
@willemneal willemneal moved this from Backlog to Todo in DevX Mar 12, 2024
willemneal added a commit that referenced this issue Mar 12, 2024
The issue was that the RPC returned a string with quotes
willemneal added a commit to AhaLabs/stellar-cli that referenced this issue Mar 12, 2024
The issue was that the RPC returned a string with quotes
@willemneal willemneal linked a pull request Mar 12, 2024 that will close this issue
willemneal added a commit to AhaLabs/stellar-cli that referenced this issue Mar 12, 2024
The issue was using debug string `{uri:?}`added quotes.
willemneal added a commit to AhaLabs/stellar-cli that referenced this issue Mar 12, 2024
The issue was using debug string `{uri:?}`added quotes.
@github-project-automation github-project-automation bot moved this from Todo to Done in DevX Mar 13, 2024
willemneal added a commit that referenced this issue Mar 13, 2024
The issue was using debug string `{uri:?}`added quotes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants