Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Code cleanup: remove duplicate code from cmd/crates/soroban-spec-tools/src/utils.rs #1544

Closed
Ifropc opened this issue Aug 12, 2024 · 0 comments · Fixed by #1635
Closed

[Chore] Code cleanup: remove duplicate code from cmd/crates/soroban-spec-tools/src/utils.rs #1544

Ifropc opened this issue Aug 12, 2024 · 0 comments · Fixed by #1635
Labels
breaking change

Comments

@Ifropc
Copy link
Contributor

Ifropc commented Aug 12, 2024

We should remove duplicate code.
Technically a breaking change because it's exported in the crate

Context: https://github.com/stellar/stellar-cli/pull/1532/files/56a81bedbbc33300fa5e2d933808a5bbd7b7b875#diff-df2803de436a816b53d1d840a2529013f8602748acf97f1413b40b57f74c80cc
#1532 (comment)
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Aug 12, 2024
@Ifropc Ifropc mentioned this issue Aug 12, 2024
Merged
@janewang janewang changed the title Code cleanup: remove duplicate code from cmd/crates/soroban-spec-tools/src/utils.rs [Chore] Code cleanup: remove duplicate code from cmd/crates/soroban-spec-tools/src/utils.rs Aug 20, 2024
@janewang janewang moved this from Backlog (Not Ready) to Todo (Ready for Dev) in DevX Aug 20, 2024
@Ifropc Ifropc mentioned this issue Sep 27, 2024
Merged
@Ifropc Ifropc linked a pull request Sep 27, 2024 that will close this issue
Code cleanup #1635
Merged
@github-project-automation github-project-automation bot moved this from Todo (Ready for Dev) to Done in DevX Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code cleanup stellar/stellar-cli
1 participant
@Ifropc