Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Deprecate getTransactionStatus.results field #339

Closed
2 tasks
Tracked by #409
paulbellamy opened this issue Jan 11, 2023 · 2 comments
Closed
2 tasks
Tracked by #409

soroban-rpc: Deprecate getTransactionStatus.results field #339

paulbellamy opened this issue Jan 11, 2023 · 2 comments
Assignees
@Shaptic
Labels
bug Something isn't working soroban-scrum

Comments

@paulbellamy
Copy link
Contributor

paulbellamy commented Jan 11, 2023 •
edited
Loading

Depends on outcome of https://docs.google.com/document/d/1hHsKxhqnakh__e986ZYBX1YIvMwUcSR97QTemiy7QKo/edit

Deprecated in #317

  • Document it as deprecated in the docs
  • Stop using it in the js client. Use resultXdr instead and parse it client-side.
@paulbellamy paulbellamy added bug Something isn't working soroban-scrum labels Jan 11, 2023
@paulbellamy paulbellamy moved this from Backlog to Next Sprint Proposal in Platform Scrum Jan 11, 2023
@paulbellamy paulbellamy moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Jan 31, 2023
@Shaptic Shaptic self-assigned this Jan 31, 2023
@tamirms tamirms mentioned this issue Feb 13, 2023
Closed
13 tasks
@Shaptic Shaptic removed their assignment Feb 13, 2023
@Shaptic Shaptic self-assigned this Feb 21, 2023
@Shaptic Shaptic moved this from Current Sprint to In Progress in Platform Scrum Feb 21, 2023
@Shaptic
Copy link
Contributor

Shaptic commented Feb 22, 2023

I believe this is implicitly closed by #438.

@Shaptic Shaptic closed this as completed Feb 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Feb 22, 2023
@Shaptic Shaptic mentioned this issue Feb 22, 2023
Closed
2 tasks
@Shaptic
Copy link
Contributor

Shaptic commented Feb 22, 2023

Ah, I see this is the "client" version of it. This will be closed by stellar/js-soroban-client#53, then.

@Shaptic Shaptic reopened this Feb 22, 2023
@tamirms tamirms closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
bug Something isn't working soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulbellamy @Shaptic @tamirms