Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Remove --captive-core-use-db flag. Force on-disk mode. #615

Closed
paulbellamy opened this issue Apr 26, 2023 · 0 comments · Fixed by #1091
Closed

soroban-rpc: Remove --captive-core-use-db flag. Force on-disk mode. #615

paulbellamy opened this issue Apr 26, 2023 · 0 comments · Fixed by #1091
Assignees
@stellarsaur
Labels
bug Something isn't working soroban-scrum
Milestone
Soroban Stable P2...

Comments

@paulbellamy
Copy link
Contributor

When we set up captive-core for soroban-rpc we copied the --captive-core-use-db (or whatever it is called) flag setup from horizon. That defaults to false in horizon for historical reasons. We should abandon that and force users to use on-disk-captive-core. Once soroban launches, the core working-state size will grow, and eventually get too big for ram, so in-memory-captive-core will not work long-term.
@paulbellamy paulbellamy added bug Something isn't working soroban-scrum labels Apr 26, 2023
@paulbellamy paulbellamy moved this from Backlog to Next Sprint Proposal in Platform Scrum Apr 26, 2023
@mollykarcher mollykarcher mentioned this issue Apr 26, 2023
Closed
3 tasks
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Backlog in Platform Scrum May 24, 2023
@mollykarcher mollykarcher added this to the Soroban Pubnet Release milestone Nov 9, 2023
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Nov 9, 2023
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Nov 15, 2023
@stellarsaur stellarsaur self-assigned this Nov 15, 2023
@stellarsaur stellarsaur linked a pull request Nov 20, 2023 that will close this issue
soroban-rpc: Force On-Disk Mode by Removing --captive-core-use-db #1091
Merged
@stellarsaur stellarsaur moved this from Current Sprint to Needs Review in Platform Scrum Nov 20, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellarsaur stellarsaur

Labels
bug Something isn't working soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
Soroban Stable P20 Release
Development

Successfully merging a pull request may close this issue.

soroban-rpc: Force On-Disk Mode by Removing --captive-core-use-db stellar/stellar-cli
3 participants
@paulbellamy @mollykarcher @stellarsaur