feat(contract invoke): support contract aliases when parsing address #1765
+263
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
feat/contract_aliases_in_sc_addr_parsing
branch
from
d391741 to
e739a46
Compare
leighmcculloch
approved these changes
Dec 2, 2024
leighmcculloch
approved these changes
Dec 2, 2024
willemneal
force-pushed
the
feat/contract_aliases_in_sc_addr_parsing
branch
from
7d710e8 to
343eeb1
Compare
Ifropc
approved these changes
Dec 2, 2024
leighmcculloch
approved these changes
Dec 3, 2024
leighmcculloch
approved these changes
Dec 3, 2024
willemneal
commented
Dec 3, 2024
…_in_sc_addr_parsing
…_in_sc_addr_parsing
…_in_sc_addr_parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1764
Currently this disallows keys and contract aliases from overlapping and in the case that they already do there is a warning and the contract is preferred.