Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-cli: fix contract deploy #937

Closed
wants to merge 1 commit into from
Closed

soroban-cli: fix contract deploy #937

wants to merge 1 commit into from

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Sep 7, 2023 •
edited
Loading

this is probably going to be scrapped out.

@2opremio
Copy link
Contributor

2opremio commented Sep 8, 2023

Can you add a test showcasing what was wrong? I added deploy tests at #940 which are working

@tsachiherman
Copy link
Contributor Author

Can you add a test showcasing what was wrong? I added deploy tests at #940 which are working

I believe @tamirms fixed the culprit in #939, but that might mean that in build_install_contract_code_tx we should remove the source_account from the operation.

@willemneal
Copy link
Member

I think that #942 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsachiherman @2opremio @willemneal