-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP-41: add mint and clawback event #1588
base: master
Are you sure you want to change the base?
Conversation
ecosystem/sep-0041.md
Outdated
Track: Standard | ||
Status: Draft | ||
Status: Final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this update should change the status. Changing the status is unnecessary and hasn't been discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to leave it in Draft
still? That seems weird if custom tokens are actively using the SEP (and will use the updated SEP with mint/clawback)
How do we decide if a SEP should be active
/final
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets have that discussion, but not bundle a status change with a functional change. The fact we're making a functional change is an indicator it still belongs in Draft, because Draft is the state that functional changes occur in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some discussion about SEP statuses in https://github.com/stellar/stellar-protocol/blob/master/ecosystem/README.md#draft-merging--further-iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's fair it should have already been updated from Draft
to Active
/Final
before these functional changes. But it's just lucky happenstance that it is still in Draft
and we can keep it in draft for these changes
Updated in b8aa496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's debatable. While the SAC implements SEP-41 there are not a significant number of custom tokens, and given the ecosystem around events is still developing (unified events work as evidence) SEP-41 still has some room to prove itself before we flag it as Final.
ecosystem/sep-0041.md
Outdated
Created: 2023-09-22 | ||
Updated: 2023-10-18 | ||
Updated: 2025-01-08 | ||
Version 0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version should be bumped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Updated in 5f29fdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I don't think we should merge it until CAP-67 is further along, just because once this is merged there's a cost to iterating on it that doesn't exist if we iterate on it in this PR.
I think this is a great step. As someone who is new to the ecosystem, I think there might be a confusion around this new change though. There is
This explanation is currently implicit, but if made explicit by putting it in SEP-41, I think a lot of confusion will be prevented, and people will better understand the design rationale behind this. P.S. needless the say, the same goes for |
Discussion
Add a
mint
andclawback
event to SEP-41 to be able to track balances through events correctlyThis does not define a
mint()
norclawback()
function. This only defines the events themselves to be SEP-41 compliant