Skip to content

Commit

Permalink
bugfix: Supply captive core path for toml generation
Browse files Browse the repository at this point in the history
When missing the captive core binary, toml generation doesn't take
Core's version and protocol into consideration, conservatively missing
version-dependent default config options.

This caused default options like `EXPERIMENTAL_BUCKETLIST_DB` and
`ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` to be missing.

Due to its implications, `CoreBinaryPath` should not be an optional
parameter.
  • Loading branch information
2opremio committed May 16, 2024
1 parent d820752 commit 0f05469
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cmd/soroban-rpc/internal/daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ func newCaptiveCore(cfg *config.Config, logger *supportlog.Entry) (*ledgerbacken
Strict: true,
UseDB: true,
EnforceSorobanDiagnosticEvents: true,
CoreBinaryPath: cfg.StellarCoreBinaryPath,
}
captiveCoreToml, err := ledgerbackend.NewCaptiveCoreTomlFromFile(cfg.CaptiveCoreConfigPath, captiveCoreTomlParams)
if err != nil {
Expand Down

0 comments on commit 0f05469

Please sign in to comment.