From 4311eefa4bf5c581df62605bd9e1bc8954f2ccda Mon Sep 17 00:00:00 2001
From: Alfonso Acosta <alfonso@stellar.org>
Date: Thu, 16 May 2024 16:27:32 +0200
Subject: [PATCH] bugfix: Supply captive core path for toml generation (#178)

When missing the captive core binary, toml generation doesn't take
Core's version and protocol into consideration, conservatively missing
version-dependent default config options.

This caused default options like `EXPERIMENTAL_BUCKETLIST_DB` and
`ENABLE_SOROBAN_DIAGNOSTIC_EVENTS` to be missing.

Due to its implications, `CoreBinaryPath` should not be an optional
parameter.
---
 cmd/soroban-rpc/internal/daemon/daemon.go | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/soroban-rpc/internal/daemon/daemon.go b/cmd/soroban-rpc/internal/daemon/daemon.go
index b09a948d..0e273f69 100644
--- a/cmd/soroban-rpc/internal/daemon/daemon.go
+++ b/cmd/soroban-rpc/internal/daemon/daemon.go
@@ -109,6 +109,7 @@ func newCaptiveCore(cfg *config.Config, logger *supportlog.Entry) (*ledgerbacken
 		Strict:                         true,
 		UseDB:                          true,
 		EnforceSorobanDiagnosticEvents: true,
+		CoreBinaryPath:                 cfg.StellarCoreBinaryPath,
 	}
 	captiveCoreToml, err := ledgerbackend.NewCaptiveCoreTomlFromFile(cfg.CaptiveCoreConfigPath, captiveCoreTomlParams)
 	if err != nil {