Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CLI error strings from stellar-rpc-client #152

Open
leighmcculloch opened this issue Apr 23, 2024 · 0 comments
Open

Remove CLI error strings from stellar-rpc-client #152

leighmcculloch opened this issue Apr 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@leighmcculloch
Copy link
Member

The stellar-rpc-client contains a CLI error string, that should really exist in the CLI itself. The stellar-rpc-client should be usable in other contexts without the CLI's error messages showing up.

For example:
https://github.com/stellar/soroban-rpc/blob/5c6d6573d5ae98e23f42c4315ce0ab268f33ed21/cmd/crates/stellar-rpc-client/src/lib.rs#L694-L696
@leighmcculloch leighmcculloch added the bug Something isn't working label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leighmcculloch