Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Maintaining retention window asynchronously in the DB #153

Closed
Tracked by #115
Shaptic opened this issue Apr 23, 2024 · 2 comments
Closed
Tracked by #115

Design: Maintaining retention window asynchronously in the DB #153

Shaptic opened this issue Apr 23, 2024 · 2 comments

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Apr 23, 2024

There is no db reingest equivalent in Soroban RPC. We should discuss the extent to which we want to support managing gaps in the database due to downtime or other inconsistencies. Options include:

  • trimming the database of everything that is not continuous on startup
  • erroring/forcing reingestion of any gaps in the retention window
  • allowing users to reingest arbitrary spans of history and/or to find/fill gaps in existing history like Horizon
  • doing nothing and just forcing users to wait for the retention window to fill before they get continuous history
  • others?

Each of these will result in a different level of work so we should decide first.

@Shaptic Shaptic changed the title Add support for ingesting into the new historical database tables Maintain retention window asynchronously across DB and in memory Apr 23, 2024
@Shaptic Shaptic changed the title Maintain retention window asynchronously across DB and in memory Design: Maintaining retention window asynchronously across DB and in memory Apr 23, 2024
@sydneynotthecity
Copy link

Objective is to write a one-pager outlining design choices and implementation details to maintain db retention window. Implementing the work is out of scope.

@Shaptic Shaptic added this to the platform sprint 46 milestone Apr 23, 2024
@Shaptic Shaptic moved this from Backlog to To Do in Platform Scrum Apr 23, 2024
@Shaptic Shaptic changed the title Design: Maintaining retention window asynchronously across DB and in memory Design: Maintaining retention window asynchronously in the DB Apr 23, 2024
@mollykarcher mollykarcher removed this from the platform sprint 48 milestone Jul 2, 2024
@mollykarcher
Copy link
Contributor

Closing as a dup of #196

@github-project-automation github-project-automation bot moved this from To Do to Done in Platform Scrum Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants