Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: optimize simulateTransaction by querying ledger entry/expiration at the same time #18

Closed
tsachiherman opened this issue Oct 13, 2023 · 1 comment
Assignees

Comments

@tsachiherman
Copy link
Contributor

Background

In stellar/stellar-cli#916, we combined the database query to retrieve the ledger key + expiration key at the same time ( for code/data entries ). The above PR also updated the RPC calls to return these.

However, the internal usage of simulateTransaction was never taking advantage of that.

Remaining work

The SnapshotSourceGet should be able to return the expiration round as well. That would allow us to make a single query from rust->go instead of two.

@mollykarcher mollykarcher changed the title soroban-rpc: use the expiration ledger during simulateTransaction soroban-rpc: optimize simulateTransaction by querying ledger entry/expiration at the same time Oct 31, 2023
@2opremio 2opremio self-assigned this Nov 8, 2023
@stellarsaur stellarsaur transferred this issue from stellar/stellar-cli Feb 1, 2024
@mollykarcher mollykarcher added this to the platform sprint 46 milestone Mar 27, 2024
@mollykarcher mollykarcher moved this from Next Sprint Proposal to Backlog in Platform Scrum Mar 27, 2024
@mollykarcher mollykarcher removed this from the platform sprint 46 milestone Jun 25, 2024
@2opremio
Copy link
Contributor

This is done by the rs-soroban-simulation library now

@github-project-automation github-project-automation bot moved this from Backlog to Done in Platform Scrum Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants