Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getHealth's retention window is broken #210

Closed
2opremio opened this issue Jun 11, 2024 · 0 comments
Closed

getHealth's retention window is broken #210

2opremio opened this issue Jun 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working rpc-sdk-scrum

Comments

@2opremio
Copy link
Contributor

2opremio commented Jun 11, 2024

It returns the transaction retention window, instead of the maximum retention window.

It broke in #174

In particular, this is not true:

https://github.com/stellar/soroban-rpc/blob/c818bb87eaaf705ca4b4c1f4b5ded8cd0cf859ff/cmd/soroban-rpc/internal/jsonrpc.go#L139-L142

The transaction window is still different than the events window, which can be larger.

@2opremio 2opremio added the bug Something isn't working label Jun 11, 2024
@aditya1702 aditya1702 moved this from Backlog to In Progress in Platform Scrum Jun 11, 2024
@aditya1702 aditya1702 added this to the platform sprint 47 milestone Jun 11, 2024
@aditya1702 aditya1702 assigned Shaptic and unassigned aditya1702 Jun 13, 2024
@aditya1702 aditya1702 moved this from In Progress to To Do in Platform Scrum Jun 13, 2024
@aditya1702 aditya1702 self-assigned this Jun 17, 2024
@aditya1702 aditya1702 moved this from To Do to In Progress in Platform Scrum Jun 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc-sdk-scrum
Projects
Status: Done
Development

No branches or pull requests

4 participants