Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getLedgerEntries() with a proxy to Core's /getledgerentry. #269

Open
Tracked by #5433
Shaptic opened this issue Aug 13, 2024 · 2 comments
Open
Tracked by #5433

Replace getLedgerEntries() with a proxy to Core's /getledgerentry. #269

Shaptic opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
go Pull requests that update Go code Protocol 23 rpc-sdk-scrum

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Aug 13, 2024

Protocol 22: Replacing Endpoints

Epic: stellar/go#5433
References: Platform's issues for Protocol 22: projects/37#31


Stellar Core will have support a high-performance HTTP endpoint for retrieving ledger entries as part of their v22 in stellar/stellar-core#4350. Once stellar/go#5426 is complete, we can completely remove the implementation of getLedgerEntries and its database backing and replace it with a proxy to the Core client.

Acceptance Criteria

The database tables are dropped.
The implementation is a proxy to Core.
The returned JSON schema stays the same.
The performance is still acceptable.

@Shaptic Shaptic changed the title Replace getLedgerEntries() implementation with a proxy to Core's /getledgerentrybulk. Replace getLedgerEntries() with a proxy to Core's /getledgerentrybulk. Aug 13, 2024
@Shaptic Shaptic added go Pull requests that update Go code Protocol 22 labels Aug 13, 2024
@Shaptic Shaptic moved this from Backlog to Blocked in Platform Scrum Aug 13, 2024
@Shaptic Shaptic changed the title Replace getLedgerEntries() with a proxy to Core's /getledgerentrybulk. Replace getLedgerEntries() with a proxy to Core's /getledgerentry. Aug 19, 2024
@2opremio 2opremio self-assigned this Aug 21, 2024
@2opremio
Copy link
Contributor

@Shaptic did you start working on this? Otherwise I will take it

@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 21, 2024

@2opremio this is blocked on Core actually providing this endpoint, but you can take it up if you want to assume the existence of Core's endpoint. I'm working on client support in stellar/go#5428 but again, no real Core yet.

Also note that we will still need entry ingestion + db snapshotting until P23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code Protocol 23 rpc-sdk-scrum
Projects
Status: To Do
Development

No branches or pull requests

4 participants