Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of EndLedger in getEvents #289

Closed
psheth9 opened this issue Sep 10, 2024 · 0 comments · Fixed by #287
Closed

Add support of EndLedger in getEvents #289

psheth9 opened this issue Sep 10, 2024 · 0 comments · Fixed by #287
Assignees
@psheth9
Labels
api-change Any changes to existing API or addition of new API rpc-sdk-scrum
Milestone
platform sprint 51

Comments

@psheth9
Copy link
Contributor

psheth9 commented Sep 10, 2024

currently getEvents are capped by 10K LedgerScanLimit which means you can query events for 10K ledger at maximum for a given request. so for a given getEvents request, we need a way to tell clients how many records we have scanned so that they could make follow up requests using endLedger or cursor

API Changes:

  • Add endLedger or Cursor details in getEventsResponse
@psheth9 psheth9 self-assigned this Sep 10, 2024
@psheth9 psheth9 added rpc-sdk-scrum api-change Any changes to existing API or addition of new API labels Sep 10, 2024
@psheth9 psheth9 added this to the platform sprint 50 milestone Sep 10, 2024
@psheth9 psheth9 moved this from Backlog to Needs Review in Platform Scrum Sep 10, 2024
@psheth9 psheth9 mentioned this issue Sep 10, 2024
Merged
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psheth9 psheth9

Labels
api-change Any changes to existing API or addition of new API rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 51
Development

Successfully merging a pull request may close this issue.

Add cursor in GetEventResponse stellar/stellar-rpc
2 participants
@aditya1702 @psheth9