-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soroban-rpc: enforce network limits during preflight #38
Comments
@sisuresh FYI |
Updated fee-related network limits:
(see the google sheet for their relation to the fee calculation) Other limits that may also need to be validated:
These value are all specified (Discussed offline with @tsachiherman and @dmkozh ) |
The limits have already been enforced in core, so I transferred the issue over here for the pending rpc work. |
Not all limits are implemented right now.
This issue tracks both adding the missing ones enforced at validation/apply time, and enforcing them during preflight.
int64 txMaxSizeBytes;
// maximum size an xdr encoded transaction can be (also enforced by thetx
endpoint)int64 txMaxGas
; // maximum gas per transactionuint32 txMaxReadLedgerEntries;
// maximum number of ledger entry read operations per transaction (footprint)int64 txMaxReadBytes;
// maximum number of bytes that can be read per transactionuint32 txMaxWriteLedgerEntries;
// maximum number of ledger entry write operations per transaction (footprint)int64 txMaxWriteBytes;
// maximum number of bytes that can be written per transactionuint32 txMaxExtendedDataSizeBytes;
// maximum size of extended data produced by a transaction (thisint64 txMaxResultSizeBytes;
// maximum size of a transaction result (gets folded intotxMaxExtendedDataSizeBytes
if we replace this by the hash in history archives)I grabbed most of this list from https://github.com/stellar/stellar-protocol/blob/master/core/cap-0046-07.md but there could be more.
The text was updated successfully, but these errors were encountered: