Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: getHealth should not fail if called with an empty parameter array. #40

Closed
paulbellamy opened this issue Feb 2, 2023 · 1 comment · Fixed by #121
Closed
Labels
bug Something isn't working

Comments

@paulbellamy
Copy link
Contributor

Currently if you call getHealth with params: [], it throws. For example:

curl -v \
  -X POST \
  --header "content-type: application/json" \
  http://localhost:8000/soroban/rpc \
  --data-binary '{"jsonrpc":"2.0", "id":2, "method":"getHealth", "params": []}'
@sreuland
Copy link
Contributor

yes, noticed similar error response on other rpc methods that don't require a params. The error message varies a bit, but appears to be same root issue of empty params: [] in the request.

@stellarsaur stellarsaur transferred this issue from stellar/stellar-cli Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Platform Scrum Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants