Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy incorrect cost object from simulateTransaction endpoint #66

Closed
janewang opened this issue Feb 15, 2024 · 1 comment
Closed

Remove legacy incorrect cost object from simulateTransaction endpoint #66

janewang opened this issue Feb 15, 2024 · 1 comment
Assignees
@2opremio
Labels
breaking-change Breaking change tag bug Something isn't working Protocol 22 rpc-sdk-scrum
Milestone
platform sprint 51

Comments

@janewang
Copy link
Collaborator

janewang commented Feb 15, 2024 •
edited
Loading

The simulateTransaction endpoint currently returns legacy cost object that is incorrect in values and confusing to developers. The correct resource costs are in the transactionData XDR. We should remove the legacy cost object.

Discord thread: https://discord.com/channels/897514728459468821/1194690264225292309

Scope of this work should include sending out the community issue for the breaking change with the stellar-community-issue-cli
@janewang janewang added the bug Something isn't working label Feb 15, 2024
@janewang janewang moved this from Backlog to To Do in Platform Scrum Apr 4, 2024
@2opremio 2opremio self-assigned this May 7, 2024
@mollykarcher mollykarcher added this to the platform sprint 47 milestone May 7, 2024
@mollykarcher mollykarcher moved this from To Do to Backlog in Platform Scrum Jun 11, 2024
@mollykarcher mollykarcher added the breaking-change Breaking change tag label Jun 18, 2024
@mollykarcher
Copy link
Contributor

We're deferring this until p22 since it is a breaking api change

@mollykarcher mollykarcher removed this from the platform sprint 48 milestone Jun 18, 2024
@mollykarcher mollykarcher moved this from Backlog to To Do in Platform Scrum Aug 27, 2024
@mollykarcher mollykarcher added this to the platform sprint 50 milestone Aug 27, 2024
@mollykarcher mollykarcher assigned Shaptic and unassigned 2opremio Sep 3, 2024
@Shaptic Shaptic removed their assignment Sep 17, 2024
@2opremio 2opremio mentioned this issue Sep 18, 2024
Merged
@aditya1702 aditya1702 moved this from To Do to Done in Platform Scrum Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
breaking-change Breaking change tag bug Something isn't working Protocol 22 rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 51
Development

No branches or pull requests
5 participants
@janewang @Shaptic @mollykarcher @2opremio @aditya1702