using newer windows sdk

stephenberry · Oct 25, 2022 · 399ef69 · 399ef69
1 parent 153e562
commit 399ef69
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/msvc.yml b/.github/workflows/msvc.yml
@@ -36,7 +36,8 @@ jobs:
       run: conan install . -b missing
 
     - name: Configure CMake
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_TOOLCHAIN_FILE="./conan/conan_toolchain.cmake"
+      # using specific windows SDK to address this issue: https://stackoverflow.com/questions/65402366/c5105-and-other-compiler-warnings-when-building-with-github-actions-winsdk-10
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_TOOLCHAIN_FILE="./conan/conan_toolchain.cmake" -DCMAKE_SYSTEM_VERSION="10.0.22621.0"
 
     - name: Build
       run: cmake --build build --config ${{env.BUILD_TYPE}} -j 2

diff --git a/.github/workflows/msvc_cpm.yml b/.github/workflows/msvc_cpm.yml
@@ -22,8 +22,9 @@ jobs:
     steps:
     - uses: actions/checkout@v3
 
+    # using specific windows SDK to address this issue: https://stackoverflow.com/questions/65402366/c5105-and-other-compiler-warnings-when-building-with-github-actions-winsdk-10
     - name: Configure CMake
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_SYSTEM_VERSION="10.0.22621.0"
 
     - name: Build
       run: cmake --build build --config ${{env.BUILD_TYPE}} -j 2