From b30cf2d22b03c1457696ca004109984428b744d7 Mon Sep 17 00:00:00 2001 From: stephengold Date: Tue, 5 Nov 2024 11:38:32 -0800 Subject: [PATCH] bugfix: some ref targets are instantiated as owners --- .../stephengold/joltjni/MotorcycleControllerSettings.java | 2 +- .../com/github/stephengold/joltjni/SoftBodySharedSettings.java | 2 +- .../stephengold/joltjni/TrackedVehicleControllerSettings.java | 2 +- .../java/com/github/stephengold/joltjni/WheelSettingsTv.java | 2 +- .../java/com/github/stephengold/joltjni/WheelSettingsWv.java | 2 +- .../stephengold/joltjni/WheeledVehicleControllerSettings.java | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/github/stephengold/joltjni/MotorcycleControllerSettings.java b/src/main/java/com/github/stephengold/joltjni/MotorcycleControllerSettings.java index ce0806e0..429255e5 100644 --- a/src/main/java/com/github/stephengold/joltjni/MotorcycleControllerSettings.java +++ b/src/main/java/com/github/stephengold/joltjni/MotorcycleControllerSettings.java @@ -37,7 +37,7 @@ public class MotorcycleControllerSettings public MotorcycleControllerSettings() { super(false); long settingsVa = createDefault(); - setVirtualAddress(settingsVa, true); + setVirtualAddress(settingsVa, false); // not owner due to ref counting } // ************************************************************************* // native private methods diff --git a/src/main/java/com/github/stephengold/joltjni/SoftBodySharedSettings.java b/src/main/java/com/github/stephengold/joltjni/SoftBodySharedSettings.java index 2a35cb79..5bf32bfe 100644 --- a/src/main/java/com/github/stephengold/joltjni/SoftBodySharedSettings.java +++ b/src/main/java/com/github/stephengold/joltjni/SoftBodySharedSettings.java @@ -42,7 +42,7 @@ public class SoftBodySharedSettings */ public SoftBodySharedSettings() { long settingsVa = createDefault(); - setVirtualAddress(settingsVa, () -> free(settingsVa)); + setVirtualAddress(settingsVa, null); // not owner due to ref counting } /** diff --git a/src/main/java/com/github/stephengold/joltjni/TrackedVehicleControllerSettings.java b/src/main/java/com/github/stephengold/joltjni/TrackedVehicleControllerSettings.java index b804689f..6ce99018 100644 --- a/src/main/java/com/github/stephengold/joltjni/TrackedVehicleControllerSettings.java +++ b/src/main/java/com/github/stephengold/joltjni/TrackedVehicleControllerSettings.java @@ -36,7 +36,7 @@ public class TrackedVehicleControllerSettings */ public TrackedVehicleControllerSettings() { long settingsVa = createDefault(); - setVirtualAddress(settingsVa, true); + setVirtualAddress(settingsVa, false); // not owner due to ref counting } /** diff --git a/src/main/java/com/github/stephengold/joltjni/WheelSettingsTv.java b/src/main/java/com/github/stephengold/joltjni/WheelSettingsTv.java index b4c89518..2d27ab86 100644 --- a/src/main/java/com/github/stephengold/joltjni/WheelSettingsTv.java +++ b/src/main/java/com/github/stephengold/joltjni/WheelSettingsTv.java @@ -36,7 +36,7 @@ public class WheelSettingsTv extends WheelSettings { public WheelSettingsTv() { super(true); long settingsVa = createDefault(); - setVirtualAddress(settingsVa, true); + setVirtualAddress(settingsVa, false); // not owner due to ref counting } /** diff --git a/src/main/java/com/github/stephengold/joltjni/WheelSettingsWv.java b/src/main/java/com/github/stephengold/joltjni/WheelSettingsWv.java index 61084a28..63f3d9a0 100644 --- a/src/main/java/com/github/stephengold/joltjni/WheelSettingsWv.java +++ b/src/main/java/com/github/stephengold/joltjni/WheelSettingsWv.java @@ -36,7 +36,7 @@ public class WheelSettingsWv extends WheelSettings { public WheelSettingsWv() { super(true); long settingsVa = createDefault(); - setVirtualAddress(settingsVa, true); + setVirtualAddress(settingsVa, false); // not owner due to ref counting } /** diff --git a/src/main/java/com/github/stephengold/joltjni/WheeledVehicleControllerSettings.java b/src/main/java/com/github/stephengold/joltjni/WheeledVehicleControllerSettings.java index 07af25ad..11d42f24 100644 --- a/src/main/java/com/github/stephengold/joltjni/WheeledVehicleControllerSettings.java +++ b/src/main/java/com/github/stephengold/joltjni/WheeledVehicleControllerSettings.java @@ -36,7 +36,7 @@ public class WheeledVehicleControllerSettings */ public WheeledVehicleControllerSettings() { long settingsVa = createDefault(); - setVirtualAddress(settingsVa, true); + setVirtualAddress(settingsVa, false); // not owner due to ref counting } /**