-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for _{digit}
in module names
#137
Comments
Okay to continue on the slack discussion let me be a bit clear on what are allowed and what are not, for module name and variable names. Not allowed:
Allowed:
So the only restriction that we can possibly relax is |
@gaow It seems that there would be more restrictions than this! Which of these are valid variable names? What about other punctuation in variable names? e.g., |
@pcarbo those are not, but i was not listing because people will mostly assume they do not work for parameters thus do not use them. Even if they do, i'll surely throw an error message. I'm just listing the ones that are normally allowed in one language but not another (1,2), one that people may very likely commit a mistake for (4) and two that would work with other languages but DSC does not allow (3,5). |
Still pending tests in DSC, but I believe this is no longer an issue (we've done some work on SoS to have it relaxed). I changed the label from |
@gaow I ran into this exact issue today (DSC 0.3.2 and SoS 0.18.4). That's why the names of my simulation modules all end in |
This is currently disallowed because it conflicts with our internal convention and violation of it causes infinite loop in DAG. This can be relaxed, though, given some work (not hard but tedious). Please bump this if it is an urgent request. Otherwise I'll not fix it immediately but perhaps in a month time or so.
The text was updated successfully, but these errors were encountered: