Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust X axis in CDF plot #114

Open
pcarbo opened this issue Dec 20, 2023 · 2 comments
Open

Adjust X axis in CDF plot #114

pcarbo opened this issue Dec 20, 2023 · 2 comments

Comments

@pcarbo
Copy link
Member

pcarbo commented Dec 20, 2023

@willwerscheid One issue I noticed with the plots is that the X axis is not adjusted for scale. For example, this is a plot I created for a normal prior with a large sd:

plot(g,incl_pm = FALSE,incl_cdf = TRUE)
Screen Shot 2023-12-20 at 7 52 56 AM

As you can see it would be helpful if the X axis could be adjusted somehow.

@pcarbo
Copy link
Member Author

pcarbo commented Dec 20, 2023

Relatedly, I noticed that the Y axis sometimes doesn't start at 0. The Y axis should always be between 0 and 1, I think?

@willwerscheid
Copy link
Member

By default the x-axis limits are chosen to span the range of the data. I agree about the y-axis and I also agree that we should have a xlim parameter in plot.ebnm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants