Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give examples showing different usage of create_mash_prior #41

Open
pcarbo opened this issue Dec 15, 2021 · 2 comments
Open

Give examples showing different usage of create_mash_prior #41

pcarbo opened this issue Dec 15, 2021 · 2 comments

Comments

@pcarbo
Copy link
Member

pcarbo commented Dec 15, 2021

@gaow Judging by the code it looks like there are three different ways to use create_mash_prior, corresponding to whether fitted_g, mixture_prior or sample_data are provided as input. Could you provide one example illustrating each of these usages?

@gaow
Copy link
Member

gaow commented Dec 15, 2021

@pcarbo I think this might be a good opportunity to rediscuss the interface. Currently you are right that there are different ways all in the same function: fitted_g extract the information from a mashr fit, mixture_prior takes in the mixture (an R list) as is, and with sample_data we will generate summary statistics to compute the mixture.

I will add examples as is, to this function. We can then determine if we want this one function to use different data types ...

@pcarbo
Copy link
Member Author

pcarbo commented Dec 15, 2021

@gaow Well, a simple alternative that might be more clear would be to have three functions instead of one. (You'd have to figure what to call these functions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants