-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3rd option in the World Covid Info. #171
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/C4nZpmvTVwMhoFtoyZTc7UVzAfnm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @stephin007
* Added Scroll to top fucntionality * added firacode font CDN * Added 3rd option in the World Covid Info. (#171) * Added single continent info(WIP) * Added continent options * Added 3rd option and added horizontal scroll(WIP) * removed width css and added text to tell user to swipe to see more data * removed width css and added text to tell user to swipe to see more data * added text to p tags * fixed css for the continent Dropdown * removed unwanted css * removed whole continents data/graph * added check for continent chart
* Added Scroll to top fucntionality * added firacode font CDN * Added 3rd option in the World Covid Info. (#171) * Added single continent info(WIP) * Added continent options * Added 3rd option and added horizontal scroll(WIP) * removed width css and added text to tell user to swipe to see more data * removed width css and added text to tell user to swipe to see more data * added text to p tags * fixed css for the continent Dropdown * removed unwanted css * removed whole continents data/graph * added check for continent chart * added conflicts workflow (#173) * added conflicts workflow 🔨 * added staging to the workflow 🔥 * changed the token name 🔨 * Added the 3rd option for showing per country covid data (#175) * Added single continent info(WIP) * Added continent options * Added 3rd option and added horizontal scroll(WIP) * removed width css and added text to tell user to swipe to see more data * removed width css and added text to tell user to swipe to see more data * added text to p tags * fixed css for the continent Dropdown * removed unwanted css * removed whole continents data/graph * added check for continent chart * uncommented the third option * updated chart content for continent view and removed dataset label * Added country dropdown for each continent * Added country flag for dataReception check * fixed img tag for vercel deployment error fix * added the correct jmespath for th destrcutured flag * added check for empty object for flags * made continent and country single select responsive * Added country card for information * Added country card for information * fixed css * Added check for the country right card to be only shown when actual data is fetched * finalised country card Co-authored-by: Justin Varghese <[email protected]>
Please check if the PR fulfills these requirements
Describe your changes
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Enhancement
What is the current behavior? (You can also link to an open issue here)
No extra options
What is the new behavior (if this is a feature change)?
Following are the expected Changes to be seen in the UI:
Removed one option and updated the second one.
Also added horizontal scroll functionality for the user to see the doughnut charts side by side rather scrolling , this gives much better UI Experience
Does this PR introduce a breaking change? (i.e changes that may require users to update/refactor existing istances of the application)
NIL
Other Information:
❤️ Thank you!