Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive dependencies? #14

Open
FezVrasta opened this issue Aug 8, 2019 · 2 comments
Open

Transitive dependencies? #14

FezVrasta opened this issue Aug 8, 2019 · 2 comments

Comments

@FezVrasta
Copy link

Am I wrong to believe the current logic won't handle transitive dependencies?

If I define foo in my dependencies list, and foo defines bar. Only foo will be added to the external list. Is this correct?

In case, is there any chance to have this addressed?

@kalbert312
Copy link

kalbert312 commented Oct 3, 2019

Possibly package-lock.json could be sourced for this? Recursive read of the requires block of each dependency.

@aweiu
Copy link

aweiu commented Sep 29, 2021

Possibly package-lock.json could be sourced for this? Recursive read of the requires block of each dependency.

Maybe:
require.resolve(moduleName).includes('/node_modules/')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants