Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimate tps and not hard-code it #76

Open
wants to merge 1 commit into
base: 1.20-1.20.1
Choose a base branch
from
Open

Estimate tps and not hard-code it #76

wants to merge 1 commit into from

Conversation

themg95
Copy link

@themg95 themg95 commented Oct 8, 2024

Fixes #7

@Steveplays28 Steveplays28 added the enhancement New feature or request / improvement of existing feature label Oct 8, 2024
@Steveplays28
Copy link
Member

Thanks for the PR themg95!
I'll merge and release it when I have time.

@Steveplays28
Copy link
Member

Steveplays28 commented Oct 8, 2024 •
edited
Loading

Looks good! I suggested a couple of changes in the review comments, would appreciate those changes if you have time.

I'll likely split up this tick mixin in the future (after the merge) for improved code quality in the mod overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request / improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't assume server TPS is 20
2 participants
@themg95 @Steveplays28