Skip to content

Commit

Permalink
&feedbackbutton tweak
Browse files Browse the repository at this point in the history
A small tweak for &feedbackbutton
(1) The &feedbackbutton only accept value by &fb (e.g., &fb=50), but &feedbackbutton=50 won't work. With this patch, both way will work.
(2) The button prompt info always show "Hear yourself at 50% volume" without dynamic showing the real user defined &fb or &feedbackbutton value. With this patch, the showing can sync with the user assigned value.
  • Loading branch information
yonghuang28 authored Nov 1, 2024
1 parent 7cb322a commit 3a4ecd0
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion main.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,12 @@ async function main() {

if (urlParams.has("feedbackbutton") || urlParams.has("fb")) {
getById("unmuteSelf").classList.remove("hidden"); // lets the director see the avatar option
session.selfVolume = urlParams.get("fb") || null;
//session.selfVolume = urlParams.get("fb") || null;
session.selfVolume = urlParams.get("feedbackbutton") || urlParams.get("fb") || null;
if (session.selfVolume){
getById("unmuteSelf").setAttribute("title", `Hear yourself at ${parseFloat(session.selfVolume)}% volume`);
getById("unmuteSelf").setAttribute("alt", `Hear yourself at ${parseFloat(session.selfVolume)}% volume`);
}
}

if (urlParams.has("controls") || urlParams.has("videocontrols")) {
Expand Down

0 comments on commit 3a4ecd0

Please sign in to comment.