Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result always show cached result #81

Open
tonymoxtra opened this issue Oct 26, 2017 · 3 comments
Open

Search result always show cached result #81

tonymoxtra opened this issue Oct 26, 2017 · 3 comments
Assignees

Comments

@tonymoxtra
Copy link

Even if I set cache limit to 0, the search result always return cached result.
What happened is if I search "A", it shows result "AX", "AY","AZ" which is fine, but if I now search "B", it still show "AX", "AY", "AZ".
I have to manually clear cache to see new result.

@steyep steyep self-assigned this Oct 27, 2017
steyep added a commit that referenced this issue Oct 27, 2017
Improves UX when caching search results
Cleans up issue formatting

Issue #81
@steyep
Copy link
Owner

steyep commented Oct 27, 2017

Thanks for creating an issue for this. I've run into that same annoyance myself but hadn't gotten around to fixing it. It's not that the search always shows the cached result, it's just that search results are persisted for 45 seconds – which can be annoying if you want to perform another search before 45 second has expired.

Anyway, I think I've come up with a working solution that isn't dependent on a timeout but still caches the results for filtering. You can checkout the feature/81-search-cache-improvements branch if you'd like to give it a shot.

steyep added a commit that referenced this issue Oct 27, 2017
@tonymoxtra
Copy link
Author

It works great now. Thank you very much @steyep

@steyep
Copy link
Owner

steyep commented Oct 27, 2017

Cool, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants