Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double tap has double logic and works incorrect #65

Open
comm1x opened this issue Oct 8, 2017 · 2 comments
Open

Double tap has double logic and works incorrect #65

comm1x opened this issue Oct 8, 2017 · 2 comments

Comments

@comm1x
Copy link

comm1x commented Oct 8, 2017

At first, thank you for your library!

Double tap in FrescoImageViewer has double logic: zoom-in/zoom-out with fixed-step and zoom-in/zoom-out with single-finger-pinch.

In Google Maps, app waits a little delay. If there was no interaction, app recognize gesture as fixed-step. If interaction was, recognize as single-finger-pinch.

FrescoImageView fires both. So when I do signle-finger-pinch (double tap with active last tap): app do zoom-in (sometimes zoom-out) and then recognizes all my finger moves as zoom.

I think, we should allow to disable some of this logics, or configure long of delay.

@troy379
Copy link
Contributor

troy379 commented Feb 19, 2018

Hi @comm1x and thank you for such interesting observation! :)
Let me know when your PR for PhotoView library will be merged and I'll be able to update it for FrescoImageViewer library. Cheers!

@comm1x
Copy link
Author

comm1x commented Feb 20, 2018

@troy379 Ok, I will :) I still observe for my pull request to PhotoView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants