Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Global Config and Generic Backend Loading from toml #5

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

BradenEverson
Copy link
Contributor

  • ✨ Create Config struct that currently just holds a Vec<BackendConfig> but could be upgraded to hold more config options later.
    • By default, Config can be loaded globally from ~/.crankshaft, but there also exists the method to manually specify a config path
  • ✨ Create Generic and Docker backend configurations, Docker is currently unimplemented.
  • ✅ Create tests for config loading and submitting to a generic backend
  • Note: Currently BackendConfig holds a simplified submit method I created just for testing the parameter replacing and script running. Once the Backend trait is created this method will be removed, and the script running functionality will be added to GenericBackend's submit implementation

@BradenEverson BradenEverson self-assigned this Sep 5, 2024
@claymcleod claymcleod force-pushed the features/backend_config branch from 5fe49ed to 6ac3a32 Compare September 5, 2024 15:20
@BradenEverson BradenEverson merged commit 92445f6 into main Sep 5, 2024
6 checks passed
@BradenEverson BradenEverson deleted the features/backend_config branch September 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants