Docker Resource Input Parsing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Gattas <[email protected]>
claymcleod
force-pushed
the
mg-docker-resources
branch
from
aac6c12 to
fbe1581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• ✨ Adds impl From<&Resources> for HostConfig { } to resources.rs
• ✨ Adds fn builder() -> Builder { } to Resources impl in resources.rs
• ✨ Adjusts fn disk_gb() in resources/builder.rs to warn about XFS disk space setting limitations
• ✨ Adds HostConfig object to service/runner/backend/docker.rs
• ✨ Adds .resources(Resources::builder()) in task Builder in examples/docker.rs
• 🔥 Adds stderr.txt and stdout.txt to .gitignore