Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charset problems #73

Open
patrickdalla opened this issue Jan 9, 2024 · 2 comments
Open

Charset problems #73

patrickdalla opened this issue Jan 9, 2024 · 2 comments
Labels

Comments

@patrickdalla
Copy link

Hello,

I started using your parser in a project. The project parsers many file types from distinct SO. So I detected charset problem.

Your parser does not change the reader charset based on the headers or tags identifying the OFX/OFC itself.

@patrickdalla
Copy link
Author

It is also difficult to change the charset, as it uses BufferedReader, so the subsequent chars were already "loaded" when the charset of the file is discovered.

@stoicflame stoicflame added the bug label Jan 9, 2024
@stoicflame
Copy link
Owner

Thanks for the report! If you apply I fix, I'm happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants