Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize image registry #22

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

geoberle
Copy link
Contributor

introduce a value parameter global.registryOverride and turn imageOverrides into image references relative to that registry

this allows us to still keep using the image defaults as defined in this chart but override the registry they are pulled from.

introduce a value parameter `global.registryOverride` and turn `imageOverrides` into image references relative to that registry

this allows us to still keep using the image defaults as defined in this chart but override the registry they are pulled from.

Signed-off-by: Gerd Oberlechner <[email protected]>
@zhiweiyin318
Copy link
Collaborator

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoberle, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Collaborator

/cherry-pick release-2.12

@openshift-cherrypick-robot

@zhiweiyin318: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 13d37e9 into stolostron:main Nov 18, 2024
2 checks passed
@openshift-cherrypick-robot

@zhiweiyin318: new pull request created: #23

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants