fix deployment always update #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @clyang82 |
|
@ldpliu Can you apply all? |
ldpliu
force-pushed
the
fix-deploywatch
branch
from
e535405 to
d2b7a89
Compare
Signed-off-by: DangPeng Liu <[email protected]>
ldpliu
force-pushed
the
fix-deploywatch
branch
from
d2b7a89 to
c48a5f6
Compare
|
|
/retest |
|
/test images |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, ldpliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When set tolerations in mgh like the following, manager and grafana deploy will always update quickly.
tolerations:
- effect: NoExecute
key: node.kubernetes.io/not-ready
operator: Exists
Related issue(s)
Fixes #
Tests
make unit-tests.make integration-test.make e2e-test-all.