fix host_ip env

Signed-off-by: Thibault Mange <[email protected]>
stolostron · Jun 3, 2024 · 75fbf57 · 75fbf57
1 parent ffd6fab
commit 75fbf57
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/operators/multiclusterobservability/controllers/placementrule/manifestwork.go b/operators/multiclusterobservability/controllers/placementrule/manifestwork.go
@@ -409,16 +409,6 @@ func createManifestWorks(
 			Value: "true",
 		})
 
-		// Add host ip env for endpoint operator. It is needed for microshift to scrape host processes metrics
-		spec.Containers[0].Env = append(spec.Containers[0].Env, corev1.EnvVar{
-			Name: "HOST_IP",
-			ValueFrom: &corev1.EnvVarSource{
-				FieldRef: &corev1.ObjectFieldSelector{
-					FieldPath: "status.hostIP",
-				},
-			},
-		})
-
 		dep.ObjectMeta.Name = config.HubEndpointOperatorName
 	}
 

diff --git a/operators/multiclusterobservability/manifests/endpoint-observability/operator.yaml b/operators/multiclusterobservability/manifests/endpoint-observability/operator.yaml
@@ -53,6 +53,10 @@ spec:
               value: "false"
             - name: PULL_SECRET
               value: "REPLACE_WITH_IMAGEPULLSECRET"
+            - name: HOST_IP # Needed for microshift
+              valueFrom:
+                fieldRef:
+                  fieldPath: status.hostIP
           volumeMounts:
             - name: hub-kubeconfig-secret
               mountPath: "/spoke/hub-kubeconfig"