-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set security context of workloads #1325
Set security context of workloads #1325
Conversation
/hold (will release once all PRs have been tested e2e) |
/retest-required |
e372071
to
d61fc09
Compare
/retest |
/retest-required |
d61fc09
to
c8acac0
Compare
/test test-e2e |
/retest |
1 similar comment
/retest |
c8acac0
to
ccef674
Compare
/retest |
f2db06b
to
6b94e1e
Compare
/retest |
Formatting was borked, making them hard to edit. Ran select ones through yamlfmt. Signed-off-by: Jacob Baungard Hansen <[email protected]>
9e1646e
to
60910f6
Compare
/retest |
1 similar comment
/retest |
This commit sets the following security context of all workloads directly handled by the operator: ``` securityContext: privileged: false readOnlyRootFilesystem: true ``` this as required by: RHOBS-1001 Signed-off-by: Jacob Baungard Hansen <[email protected]>
This commit sets the following security context for the metric collector pods: ``` securityContext: privileged: false readOnlyRootFilesystem: true ``` this as required by: RHOBS-1001 Signed-off-by: Jacob Baungard Hansen <[email protected]>
This commit sets the following security context for the endpoint-observability-operator ``` securityContext: privileged: false readOnlyRootFilesystem: true ``` this as required by: RHOBS-1001 Signed-off-by: Jacob Baungard Hansen <[email protected]>
Otherwise fsGroup in the security context fails. Signed-off-by: Jacob Baungard Hansen <[email protected]>
dd6f746
to
d31af64
Compare
|
/retest |
- observatorium-operator | ||
topologyKey: topology.kubernetes.io/zone | ||
weight: 70 | ||
- podAffinityTerm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the yaml is being formatted differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some formatting inconsistencies before (or at least my eyes struggled with the formatting), so I ran the files I needed to change through yamllint
as I found it hard to make changes correctly otherwise.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobbaungard, moadz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This commit sets the following security context of all workloads
directly handled by the operator:
this as required by: RHOBS-1001