Fix issue with views reconfigure

story-apps · Dec 12, 2022 · a2d5c09 · a2d5c09
1 parent 88863a5
commit a2d5c09
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 7 deletions.
diff --git a/src/core/management_layer/plugins/comic_book_text/comic_book_text_manager.cpp b/src/core/management_layer/plugins/comic_book_text/comic_book_text_manager.cpp
@@ -322,7 +322,11 @@ void ComicBookTextManager::resetModels()
 
 void ComicBookTextManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void ComicBookTextManager::bind(IDocumentManager* _manager)

diff --git a/src/core/management_layer/plugins/screenplay_cards b/src/core/management_layer/plugins/screenplay_cards
diff --git a/src/core/management_layer/plugins/screenplay_text/screenplay_text_manager.cpp b/src/core/management_layer/plugins/screenplay_text/screenplay_text_manager.cpp
@@ -550,7 +550,11 @@ void ScreenplayTextManager::resetModels()
 
 void ScreenplayTextManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void ScreenplayTextManager::bind(IDocumentManager* _manager)

diff --git a/src/core/management_layer/plugins/screenplay_treatment/screenplay_treatment_manager.cpp b/src/core/management_layer/plugins/screenplay_treatment/screenplay_treatment_manager.cpp
@@ -323,7 +323,11 @@ void ScreenplayTreatmentManager::resetModels()
 
 void ScreenplayTreatmentManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void ScreenplayTreatmentManager::bind(IDocumentManager* _manager)

diff --git a/src/core/management_layer/plugins/simple_text/simple_text_manager.cpp b/src/core/management_layer/plugins/simple_text/simple_text_manager.cpp
@@ -320,7 +320,11 @@ void SimpleTextManager::resetModels()
 
 void SimpleTextManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void SimpleTextManager::bind(IDocumentManager* _manager)

diff --git a/src/core/management_layer/plugins/stageplay_text/stageplay_text_manager.cpp b/src/core/management_layer/plugins/stageplay_text/stageplay_text_manager.cpp
@@ -321,7 +321,11 @@ void StageplayTextManager::resetModels()
 
 void StageplayTextManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void StageplayTextManager::bind(IDocumentManager* _manager)

diff --git a/src/core/management_layer/plugins/title_page/title_page_manager.cpp b/src/core/management_layer/plugins/title_page/title_page_manager.cpp
@@ -238,7 +238,11 @@ void TitlePageManager::resetModels()
 
 void TitlePageManager::reconfigure(const QStringList& _changedSettingsKeys)
 {
-    d->view->reconfigure(_changedSettingsKeys);
+    for (const auto& view : std::as_const(d->allViews)) {
+        if (!view.view.isNull()) {
+            view.view->reconfigure(_changedSettingsKeys);
+        }
+    }
 }
 
 void TitlePageManager::saveSettings()